Change in osmocom-bb[master]: mobile/gsm48_rr.c: fix NULL-pointer dereference in gsm48_rr_check_mode()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16087 )


Change subject: mobile/gsm48_rr.c: fix NULL-pointer dereference in gsm48_rr_check_mode()
......................................................................

mobile/gsm48_rr.c: fix NULL-pointer dereference in gsm48_rr_check_mode()

In some cases (e.g. at start up) ms->rrlayer may not be initialized.
Let's access ms->settings directly since we already have a pointer
to struct osmocom_ms.

Change-Id: Ia9720132fcda960dcecefab9ae48398946503dc4
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/87/16087/1

diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index 254183e..b3da258 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -319,7 +319,7 @@
 int gsm48_rr_alter_delay(struct osmocom_ms *ms)
 {
 	struct gsm48_rrlayer *rr = &ms->rrlayer;
-	struct gsm_settings *set = &rr->ms->settings;
+	struct gsm_settings *set = &ms->settings;
 
 	if (rr->state != GSM48_RR_ST_DEDICATED)
 		return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/16087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9720132fcda960dcecefab9ae48398946503dc4
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191117/c439ebae/attachment.htm>