Change in osmo-bts[master]: bts-trx: loops.c: Avoid always clamping MS power to MS power class 1

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16069 )

Change subject: bts-trx: loops.c: Avoid always clamping MS power to MS power class 1
......................................................................

bts-trx: loops.c: Avoid always clamping MS power to MS power class 1

The affirmation written there is not true, since actually it depends on
the band. For instance, for DCS1800 the maximum MS power is provided by
class 3. Let ms_pwr_ctl_lvl() take care of campling instead.

Change-Id: I744e7c315b818a1e7d3dd2579cd483c693d89b73
---
M src/osmo-bts-trx/loops.c
1 file changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index 4b723a0..1f54fee 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -49,7 +49,7 @@
 	struct gsm_bts_trx *trx = lchan->ts->trx;
 	enum gsm_band band = trx->bts->band;
 	int8_t new_power; /* TS 05.05 power level */
-	int8_t new_dbm, current_dbm, bsc_max_dbm, pwclass_max_dbm;
+	int8_t new_dbm, current_dbm, bsc_max_dbm;
 
 	/* power levels change in steps of 2 dB, so a smaller diff will end up in no change */
 	if (diff < 2 && diff > -2)
@@ -89,15 +89,6 @@
 	if (new_dbm > bsc_max_dbm)
 		new_dbm = bsc_max_dbm;
 
-	/* Make sure in no case the dBm value is higher than the one of ms
-	   power class 1 (the one with more output power) for the given band.
-	   Ideally we should catch the MS specific power class and apply it
-	   here, but for now let's assume the BSC sent us one taking the power
-	   class into account. */
-	pwclass_max_dbm = (int)ms_class_gmsk_dbm(band, 1);
-	if (pwclass_max_dbm >= 0 && new_dbm > pwclass_max_dbm)
-		new_dbm = pwclass_max_dbm;
-
 	new_power = ms_pwr_ctl_lvl(band, new_dbm);
 	if (new_power < 0) {
 		LOGPLCHAN(lchan, DLOOP, LOGL_NOTICE,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16069
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I744e7c315b818a1e7d3dd2579cd483c693d89b73
Gerrit-Change-Number: 16069
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191115/169daeb0/attachment.htm>