Change in osmo-bts[master]: rsl: Remove unneeded duplicate reset on some lchan fields

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Nov 15 14:49:50 UTC 2019


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16061 )

Change subject: rsl: Remove unneeded duplicate reset on some lchan fields
......................................................................

rsl: Remove unneeded duplicate reset on some lchan fields

Both ms_power and ms_power_ctrl are reset to 0 again further below.

Change-Id: Ia2a5da068d440232361d57bd5ac33eddebf05ebe
---
M src/common/rsl.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 9a4afb3..f88d2d7 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -997,9 +997,6 @@
 {
 	/* These values don't apply to PDCH, just clear them. Particularly the encryption must be
 	 * cleared, or we would enable encryption on PDCH with parameters remaining from the TCH. */
-	lchan->ms_power = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0);
-	lchan->ms_power_ctrl.current = lchan->ms_power;
-	lchan->ms_power_ctrl.fixed = false;
 	lchan->rsl_cmode = 0;
 	lchan->tch_mode = 0;
 	memset(&lchan->encr, 0, sizeof(lchan->encr));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia2a5da068d440232361d57bd5ac33eddebf05ebe
Gerrit-Change-Number: 16061
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191115/632b7fe9/attachment.htm>


More information about the gerrit-log mailing list