Change in osmo-bts[master]: power_control.c: Apply latests improvements from loops.c

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16070 )

Change subject: power_control.c: Apply latests improvements from loops.c
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review+1
> 
> LGTM.
> 
> I've noticed that osmo-bts-trx also has code to not change more than MS_{LOWER,RAISE}_MAX_DBM at once. Why was that omitted from the port?

Because the algo works slightly different. The one from loops.c was not receiving the currently used MS Power Level announced during the block, probably because the algo works on bursts instead of the entire block, so the content of the block is not available because it works at a lower layer. On the other hand, since the power_control.c one works on blocks received from lower layer, then the MS Power control being used by the MS matching the rx signal strength is available, so the algo can use that to know if the MS already reached the last announced power level.

So, instead of making sure it changes the power level at a rate acceptable for the MS, it simply changes to the calculated desired one and waits for the MS to reach the power level until applying corrections again based on received signal strength.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I579967cc8bb69dc76a315c6c9d3a351f5961d92f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Nov 2019 14:48:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191115/59c24945/attachment.htm>