Change in osmo-remsim[master]: bankd_client_fsm: close IPA client connection before re-establishing it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 7 12:13:36 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/15997 )


Change subject: bankd_client_fsm: close IPA client connection before re-establishing it
......................................................................

bankd_client_fsm: close IPA client connection before re-establishing it

ipa_client_conn_destroy() really only destroys the object, but not close
the underlying file descriptor.  This leads to old connections
lingering around, which in turn (in case of the remsim client) will
occupy banksim worker threads.

Change-Id: If87f4bbc133e4dc812fa96a75e8495bad65275aa
---
M src/bankd_client_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/97/15997/1

diff --git a/src/bankd_client_fsm.c b/src/bankd_client_fsm.c
index 8cc773a..cedb597 100644
--- a/src/bankd_client_fsm.c
+++ b/src/bankd_client_fsm.c
@@ -152,6 +152,7 @@
 	/* re-create bankd_conn */
 	if (bc->bankd_conn) {
 		LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to bankd\n");
+		ipa_client_conn_close(bc->bankd_conn);
 		ipa_client_conn_destroy(bc->bankd_conn);
 		bc->bankd_conn = NULL;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/15997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: If87f4bbc133e4dc812fa96a75e8495bad65275aa
Gerrit-Change-Number: 15997
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191107/833a9011/attachment.htm>


More information about the gerrit-log mailing list