Change in libosmo-sccp[master]: Allow ASP role to be configured

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15974 )

Change subject: Allow ASP role to be configured
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15974/3/src/osmo_ss7_vty.c 
File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15974/3/src/osmo_ss7_vty.c@734 
PS3, Line 734: 	if (asp->cfg.role_set_by_vty) {
> If this flag is only used this way, I don't see the point in having it. […]
the vty code is also used by classic M3UA clients.  Here, the default is ASP_ROLE_ASP.  So if we ever were to run a MSC/BSC with mode != ASP, or a STP with mode != SG, then the vty config line will be written.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15974
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I2df9cd9747ad5c9a05d567d9a71bab6184c53674
Gerrit-Change-Number: 15974
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Nov 2019 20:05:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/2888e28f/attachment.htm>