Change in libosmo-sccp[master]: xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15892 )

Change subject: xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK
......................................................................

xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK

IF we cannot activate the ASP in response to an ASPAC, we should
return just the error and not an error + ASPACK_ACK.

Change-Id: I681021a13af9b91d8b2b849bd7149d6b1f783865
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 890a6b5..a6ee2ec 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -457,7 +457,7 @@
 			    traf_mode != M3UA_TMOD_LOADSHARE &&
 			    traf_mode != M3UA_TMOD_BCAST) {
 				peer_send_error(fi, M3UA_ERR_UNSUPP_TRAF_MOD_TYP);
-				break;
+				return;
 			}
 		}
 		if ((part = xua_msg_find_tag(xua_in, M3UA_IEI_ROUTE_CTX))) {
@@ -465,7 +465,7 @@
 				rctx = osmo_load32be(&part->dat[i * sizeof(uint32_t)]);
 				if (!osmo_ss7_as_find_by_rctx(asp->inst, rctx)) {
 					peer_send_error(fi, M3UA_ERR_INVAL_ROUT_CTX);
-					break;
+					return;
 				}
 			}
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I681021a13af9b91d8b2b849bd7149d6b1f783865
Gerrit-Change-Number: 15892
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/cd69fbe1/attachment.htm>