This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15885 ) Change subject: M3UA: Reject ASP activation + RKM registration for incompatible traffic-mode ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/3/include/osmocom/sigtran/osmo_ss7.h File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/3/include/osmocom/sigtran/osmo_ss7.h@319 PS3, Line 319: /* traffic mode was configured by RKM (routing key management) */ > AFAIU not only by RKM, but by first ASPAC too. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/3/include/osmocom/sigtran/osmo_ss7.h@531 PS3, Line 531: bool osmo_ss7_as_tmode_compatible_xua(struct osmo_ss7_as *as, uint32_t m3ua_tmt); > This one should go togehter with other osmo_ss7_as_* APIs around line 349. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/3/src/xua_asp_fsm.c File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/3/src/xua_asp_fsm.c@459 PS3, Line 459: return; > Ah you fixed it here. I'd be better on the other commit but fine. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/3/src/xua_asp_fsm.c@470 PS3, Line 470: if (traf_mode) { /* if the peer has specified a traffic mode at all */ > I'm thinking that inside here we should have similar to what we have in RKM: if (!as->cfg. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic73410fbc88d50710202453f759fa132ce14db4c Gerrit-Change-Number: 15885 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 05 Nov 2019 17:51:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/bd174dd6/attachment.htm>