Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

[neels]

Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-msc/+/15947

to look at the new patch set (#2).

Change subject: add sdp_msg API: SDP parsing/composition
......................................................................

add sdp_msg API: SDP parsing/composition

Rationale: in order to add full SDP to the MNCC protocol (upcoming patch
I8c3b2de53ffae4ec3a66b9dabf308c290a2c999f), we need to parse and compose SDP
messages. Obviously, libosmo-mgcp-client already contains similar code, but
that is unfortunately heavily glued to the actual MGCP implementation. The
simplest solution is to create this separate implementation, copy-pasting from
the existing libosmo-mgcp-client code as is convenient.

Various foo_name() functions are implemented for the sdp_msg API.
Each is:
a) implemented as foo_name_buf(buf, len, val),
b) wrapped as foo_name_c(ctx, val)
c) and as foo_name(val), a convienience variant using OTC_SELECT.

(a) foo_name_buf() uses osmo_strbuf to write to a fixed-size caller provided
buffer: osmo_strbuf is most convenient to implement optional parts / loops.

(b) foo_name_c() uses a caller-provided talloc ctx to allocate such buffer;
implemented using a generalized NAME_C_IMPL(func_buf, arg) macro, which calls
func with an initial size buffer, and reallocates if more space is needed.

(c) foo_name() then calls foo_name_c() with the OTC_SELECT context (we know that
msc_main.c uses osmo_select_main_ctx()), implemented using a generalized
NAME_IMPL() macro, and returns "ERROR" on failure instead of NULL.

Change-Id: If3ce23cd5bab15e2ab4c52ef3e4c75979dffe931
---
M configure.ac
M include/osmocom/msc/Makefile.am
A include/osmocom/msc/sdp_msg.h
M src/libmsc/Makefile.am
A src/libmsc/sdp_msg.c
M tests/Makefile.am
A tests/sdp_msg/Makefile.am
A tests/sdp_msg/sdp_msg_test.c
A tests/sdp_msg/sdp_msg_test.err
A tests/sdp_msg/sdp_msg_test.ok
M tests/testsuite.at
11 files changed, 1,846 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/47/15947/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If3ce23cd5bab15e2ab4c52ef3e4c75979dffe931
Gerrit-Change-Number: 15947
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191105/375f1df5/attachment.htm>