This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 ) Change subject: add sdp_msg API: SDP parsing/composition ...................................................................... Patch Set 1: > Patch Set 1: > > doesn't it much rather make sense to have at least a helper library containing those things that you are copy+pasting here? something like libosmo-sdp-utils, which then can be used by any of the actual parser codebases? Copy+Pasting of such code really hurts me :/ Indeed, but my idea was to do that in a separate patch set. I didn't want to blow up the current task. When we want to use this SDP parsing in osmo-mgw, that likely triggers a rund of MGCP refactoring. I have plans there, being that we should be able to fully control SDP in MGCP messages instead of using the struct mgcp_conn_peer (so far a bit of a bottleneck for what we are able to express in SDP). That also has implications for osmo-bsc. So it is sort of a perpendicular other task with tails on it. We could add an SDP lib in osmo-mgw without using it there... but: To not get pulled into that and to not stretch this patch across git reposes, I thought of this as an SDP parsing incubator, and we can move to osmo-mgw (or libosmocore even) when it has matured. I guess it has pretty much matured when this patch set gets accepted, and we can decide when to apply in osmo-mgw. Does that sound acceptable? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If3ce23cd5bab15e2ab4c52ef3e4c75979dffe931 Gerrit-Change-Number: 15947 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2019 15:14:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191104/c7cd38f8/attachment.htm>