Change in osmo-msc[master]: fsm: use deferred deallocation

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15850 )

Change subject: fsm: use deferred deallocation
......................................................................

fsm: use deferred deallocation

Since osmo-bsc uses the MGCP client FSMs, it is required to enable this new
feature to guarantee safe operation. The issue is described in detail in commit
logs linked below.

Notably, osmo-msc currently chooses to omit error handling during MGCP events
(marked "FIXME"). An upcoming patch implements this error handling, and would
make osmo-msc vulnerable to crash from unexpected MGCP messages without this.

Deferred FSM deallocation is a more general, simpler approach to
osmo_fsm_term_safely(), so we can switch that off now.

Depends: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78 (libosmocore),
         I0adc13a1a998e953b6c850efa2761350dd07e03a (libosmocore)
Related: I7df2e9202b04e7ca7366bb0a8ec53cf3bb14faf3 (osmo-mgw)
Change-Id: I08c03946605aa12e0a5ce8b3c773704ef5327a7a
---
M src/osmo-msc/msc_main.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 3860589..43a1fcb 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -500,7 +500,7 @@
 	/* Track the use of talloc NULL memory contexts */
 	talloc_enable_null_tracking();
 
-	osmo_fsm_term_safely(true);
+	osmo_fsm_set_dealloc_ctx(OTC_SELECT);
 
 	msc_vty_info.copyright	= osmomsc_copyright;
 
@@ -721,7 +721,7 @@
 
 	while (!quit) {
 		log_reset_context();
-		osmo_select_main(0);
+		osmo_select_main_ctx(0);
 	}
 
 	msc_network_shutdown(msc_network);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15850
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I08c03946605aa12e0a5ce8b3c773704ef5327a7a
Gerrit-Change-Number: 15850
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191104/8ddcaba6/attachment.htm>