This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15888 )
Change subject: l1sap: add measurement related struct members
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/15888/3/include/osmocom/gsm/l1sap.h
File include/osmocom/gsm/l1sap.h:
https://gerrit.osmocom.org/c/libosmocore/+/15888/3/include/osmocom/gsm/l1sap.h@99
PS3, Line 99: int16_t ta_offs_qbits; /*!< timing advance offset (in qbits) */
: int16_t ta_offs_256bits;/*!< timing advance offset (in 1/256th bits) */
why a union why not always stort 256ths? If somebody has or wants a quarter-bit, they cna do the bit-shifting themselves?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2c34b02d329f9df190c5035c396403ca0a4f9c42
Gerrit-Change-Number: 15888
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 15:09:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191101/44123436/attachment.htm>