Change in libosmocore[master]: sim: allow opening reader# > 0

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15927 )

Change subject: sim: allow opening reader# > 0
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/15927/3/utils/osmo-sim-test.c 
File utils/osmo-sim-test.c:

https://gerrit.osmocom.org/c/libosmocore/+/15927/3/utils/osmo-sim-test.c@339 
PS3, Line 339: f(argc > 1)
             : 		readernum = atoi(argv[1]);
I would prefer some proper getopt here, rather than just using the full argument.  The tool is likely to get more options in the future, meaning named arguments are better than positional arguments.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15927
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4b1abc8d8aae4bd9a32f927269d7ebfef902d7c5
Gerrit-Change-Number: 15927
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 15:08:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191101/55dd7372/attachment.htm>