Change in osmo-ttcn3-hacks[master]: PCU: Fully implement TC_pcu_data_req_{pdtch, ptcch}

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14183 )

Change subject: PCU: Fully implement TC_pcu_data_req_{pdtch,ptcch}
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Not a merge blocker, just some of my thoughts about GPRS support in OsmocomBB...

https://gerrit.osmocom.org/#/c/14183/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/14183/3//COMMIT_MSG@9
PS3, Line 9: trxcon+fake_trx don't have GPRS (TBF) support yet
Ah, yep. Actually, trxcon gives you low-level access to the PDCH channels, just like OsmoBTS to OsmoPCU, so you can Rx/Tx both PDTCH and PTCCH blocks. I don't think it's a good idea to overload trxcon (and L1CTL too, but it's already modified) with GPRS specific stuff like TBF filtering - this can be implemented on the higher layers (i.e. here). This approach would (I believe) give the user more flexibility.


https://gerrit.osmocom.org/#/c/14183/3/bts/BTS_Tests_virtphy.ttcn
File bts/BTS_Tests_virtphy.ttcn:

https://gerrit.osmocom.org/#/c/14183/3/bts/BTS_Tests_virtphy.ttcn@51
PS3, Line 51: tr_L1CTL_DATA_IND
Regarding the use of L1CTL_DATA_* messages: their length is limited to 23:

  struct l1ctl_data_ind {
    uint8_t data[23];
  };

Maybe we should rather use L1CTL_TRAFFIC_* for that?



-- 
To view, visit https://gerrit.osmocom.org/14183
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I677f660b1076148b3317b08b06eb3d6551d9b577
Gerrit-Change-Number: 14183
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 26 May 2019 18:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190526/ea1ac92c/attachment.htm>