Change in osmo-bsc[master]: Allow VTY to set the CCCH Load Indication Threshold

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat May 25 09:01:19 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/14174


Change subject: Allow VTY to set the CCCH Load Indication Threshold
......................................................................

Allow VTY to set the CCCH Load Indication Threshold

Add a new VTY command "ccch load-indication-threshold <0-100>"
by which the user can configure the threshold after which the BTS
shall send CCCH LOAD IND.  It used to be hard-coded to a
default value of 10.

Change-Id: I059fe4627438e26a06e00d84e342b736ab7af440
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
M src/osmo-bsc/gsm_data.c
4 files changed, 23 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/14174/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 82bd238..a464001 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1115,6 +1115,9 @@
 		bool ctrl_ack_type_use_block;
 	} gprs;
 
+	/* threshold (in percent) when BTS shall send CCCH LOAD IND */
+	int ccch_load_ind_thresh;
+
 	/* RACH NM values */
 	int rach_b_thresh;
 	int rach_ldavg_slots;
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index af25cab..9b5cd40 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -848,6 +848,9 @@
 	vty_out(vty, "  channel-descrption bs-ag-blks-res %u%s",
 		bts->si_common.chan_desc.bs_ag_blks_res, VTY_NEWLINE);
 
+	if (bts->ccch_load_ind_thresh != 10)
+		vty_out(vty, "  ccch load-indication-threshold %u%s",
+			bts->ccch_load_ind_thresh, VTY_NEWLINE);
 	if (bts->rach_b_thresh != -1)
 		vty_out(vty, "  rach nm busy threshold %u%s",
 			bts->rach_b_thresh, VTY_NEWLINE);
@@ -2434,6 +2437,20 @@
 	return CMD_SUCCESS;
 }
 
+#define CCCH_STR "Common Control Channel\n"
+
+DEFUN(cfg_bts_ccch_load_ind_thresh,
+      cfg_bts_ccch_load_ind_thresh_cmd,
+      "ccch load-indication-threshold <0-100>",
+	CCCH_STR
+      "Percentage of CCCH load at which BTS sends RSL CCCH LOAD IND\n"
+      "CCCH Load Threshold in percent")
+{
+	struct gsm_bts *bts = vty->index;
+	bts->ccch_load_ind_thresh = atoi(argv[0]);
+	return CMD_SUCCESS;
+}
+
 #define NM_STR "Network Management\n"
 
 DEFUN(cfg_bts_rach_nm_b_thresh,
@@ -5233,6 +5250,7 @@
 	install_element(BTS_NODE, &cfg_bts_chan_desc_att_cmd);
 	install_element(BTS_NODE, &cfg_bts_chan_desc_bs_pa_mfrms_cmd);
 	install_element(BTS_NODE, &cfg_bts_chan_desc_bs_ag_blks_res_cmd);
+	install_element(BTS_NODE, &cfg_bts_ccch_load_ind_thresh_cmd);
 	install_element(BTS_NODE, &cfg_bts_rach_nm_b_thresh_cmd);
 	install_element(BTS_NODE, &cfg_bts_rach_nm_ldavg_cmd);
 	install_element(BTS_NODE, &cfg_bts_cell_barred_cmd);
diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
index 8a370da..be823ae 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
@@ -60,7 +60,7 @@
 	msgb_tv_fixed_put(msgb, NM_ATT_OVERL_PERIOD, 3, buf);
 
 	/* percent */
-	msgb_tv_put(msgb, NM_ATT_CCCH_L_T, 10);
+	msgb_tv_put(msgb, NM_ATT_CCCH_L_T, bts->ccch_load_ind_thresh);
 
 	/* seconds */
 	msgb_tv_put(msgb, NM_ATT_CCCH_L_I_P, 1);
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 5942fba..ea33817 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -827,6 +827,7 @@
 	}
 	bts->c0->ts[0].pchan_from_config = GSM_PCHAN_CCCH_SDCCH4; /* TODO: really?? */
 
+	bts->ccch_load_ind_thresh = 10; /* 10% of Load: Start sending CCCH LOAD IND */
 	bts->rach_b_thresh = -1;
 	bts->rach_ldavg_slots = -1;
 

-- 
To view, visit https://gerrit.osmocom.org/14174
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I059fe4627438e26a06e00d84e342b736ab7af440
Gerrit-Change-Number: 14174
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190525/0f8685e9/attachment.htm>


More information about the gerrit-log mailing list