Change in osmo-msc[master]: libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon May 13 20:15:05 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13967 )

Change subject: libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT
......................................................................

libmsc/sgs_server.c: do not override rc in case of SCTP_SHUTDOWN_EVENT

Change-Id: I06215a7d3dc33f2e8adb77fa1b3f2ac5198dee26
Fixes: CID#190867
---
M src/libmsc/sgs_server.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/sgs_server.c b/src/libmsc/sgs_server.c
index 28c42cb..779e12c 100644
--- a/src/libmsc/sgs_server.c
+++ b/src/libmsc/sgs_server.c
@@ -40,7 +40,7 @@
 	struct msgb *msg = gsm29118_msgb_alloc();
 	struct sctp_sndrcvinfo sinfo;
 	int flags = 0;
-	int rc;
+	int rc = 0;
 
 	/* we cannot use osmo_stream_srv_recv() here, as we might get some out-of-band info from
 	 * SCTP. FIXME: add something like osmo_stream_srv_recv_sctp() to libosmo-netif and use
@@ -72,7 +72,6 @@
 		default:
 			break;
 		}
-		rc = 0;
 		goto out;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/13967
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I06215a7d3dc33f2e8adb77fa1b3f2ac5198dee26
Gerrit-Change-Number: 13967
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190513/1656c97d/attachment.htm>


More information about the gerrit-log mailing list