Change in libosmo-sccp[master]: osmo-stp: refactor handling of both SIGINT and SIGTERM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun May 12 10:43:31 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13971 )

Change subject: osmo-stp: refactor handling of both SIGINT and SIGTERM
......................................................................


Patch Set 1:

> actually, that won't work. [...] your sleep here won't help.

Well, let's first clarify that it's not my sleep() - I just moved it from signal_handler(), together with osmo_signal_dispatch(). This sleep() was also looking confusing to me, since we also do this in OsmoMSC (https://git.osmocom.org/osmo-msc/tree/src/osmo-msc/msc_main.c#n748) and OsmoBSC (https://git.osmocom.org/osmo-bsc/tree/src/osmo-bsc/osmo_bsc_main.c#n638).

In this patch I just wanted to facilitate printing both root and NULL talloc contexts on exit (see next change). Not sure, if I have time to work on graceful shutdown. I think we need to create an issue, and generalize this process somehow for all projects...


-- 
To view, visit https://gerrit.osmocom.org/13971
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d8618857c5119d4acca5d65cf1276ab02889c84
Gerrit-Change-Number: 13971
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 12 May 2019 10:43:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190512/45380f65/attachment.htm>


More information about the gerrit-log mailing list