Change in osmo-msc[master]: libmsc/gsm_04_11.c: fix double init of both SMR and SMC FSMs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat May 11 21:06:43 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/14000


Change subject: libmsc/gsm_04_11.c: fix double init of both SMR and SMC FSMs
......................................................................

libmsc/gsm_04_11.c: fix double init of both SMR and SMC FSMs

Change-Id: I23700a2c575a96057ef22bc5d8ab6271104d619b
---
M src/libmsc/gsm_04_11.c
1 file changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/00/14000/1

diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 22e55dd..cc9ce18 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -1012,10 +1012,6 @@
 		return NULL;
 	}
 
-	/* Init both SMC and SMR state machines */
-	gsm411_smc_init(&trans->sms.smc_inst, 0, 1, gsm411_mn_recv, gsm411_mm_send);
-	gsm411_smr_init(&trans->sms.smr_inst, 0, 1, gsm411_rl_recv, gsm411_mn_send);
-
 	if (msc_a) {
 		msc_a_get(msc_a, MSC_A_USE_SMS);
 		trans->msc_a = msc_a;

-- 
To view, visit https://gerrit.osmocom.org/14000
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23700a2c575a96057ef22bc5d8ab6271104d619b
Gerrit-Change-Number: 14000
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190511/9a3b3e75/attachment.htm>


More information about the gerrit-log mailing list