This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13975 Change subject: libmsc/msc_ho.c: fix unreacheable check of MSC-T role allocation ...................................................................... libmsc/msc_ho.c: fix unreacheable check of MSC-T role allocation Change-Id: I46fa37ff27e8a4576fdc8edad894ee16759a6e7a Fixes: CID#198413 --- M src/libmsc/msc_ho.c 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/75/13975/1 diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c index 3a4258c..615b8cd 100644 --- a/src/libmsc/msc_ho.c +++ b/src/libmsc/msc_ho.c @@ -463,9 +463,8 @@ msc_i->ran_conn->ran_peer->fi->id, rp->fi->id); } - msc_t_alloc(msc_a->c.msub, rp); - msc_ho_send_handover_request(msc_a); - return; + msc_t = msc_t_alloc(msc_a->c.msub, rp); + break; case MSC_NEIGHBOR_TYPE_REMOTE_MSC: ipa_name = msc_a->ho.new_cell.msc_ipa_name; @@ -482,22 +481,24 @@ osmo_quote_str(ipa_name, -1)); } - msc_t_remote_alloc(msc_a->c.msub, msc_a->c.ran, (const uint8_t*)ipa_name, strlen(ipa_name)); - msc_ho_send_handover_request(msc_a); - return; + msc_t = msc_t_remote_alloc(msc_a->c.msub, msc_a->c.ran, + (const uint8_t *) ipa_name, + strlen(ipa_name)); + break; default: msc_ho_try_next_cell(msc_a, "unknown Handover target type %d\n", msc_a->ho.new_cell.type); return; } - msc_t = msc_a_msc_t(msc_a); if (!msc_t) { /* There should definitely be one now. */ msc_ho_failed(msc_a, GSM0808_CAUSE_EQUIPMENT_FAILURE, "Cannot initiate Handover Request, failed to set up a target MSC-T\n"); return; } + + msc_ho_send_handover_request(msc_a); } static void msc_ho_rx_request_ack(struct msc_a *msc_a, struct msc_a_ran_dec_data *hra); -- To view, visit https://gerrit.osmocom.org/13975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I46fa37ff27e8a4576fdc8edad894ee16759a6e7a Gerrit-Change-Number: 13975 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/3d3ea27e/attachment.htm>