Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Fix IMSI table lookup on RANAP paging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 9 22:47:26 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13959 )

Change subject: RAN_Emulation: Fix IMSI table lookup on RANAP paging
......................................................................

RAN_Emulation: Fix IMSI table lookup on RANAP paging

We need to check explicitly for '== null'.  isvalue() is of no help
here, as 'null' apparently is a value in TTCN-3.

Change-Id: I4b2793937a201c5535051092d871ded6cb053f5f
---
M library/RAN_Emulation.ttcnpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index 843cc9e..9a65eb7 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -585,7 +585,7 @@
 			}
 		}
 		client := f_imsi_table_find(oct2hex(imsi), tmsi);
-		if (isvalue(client)) {
+		if (client != null) {
 			log("CommonRanapUnitdataCallback: IMSI/TMSI found in table, dispatching to ",
 				client);
 			CLIENT.send(ranap) to client;

-- 
To view, visit https://gerrit.osmocom.org/13959
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b2793937a201c5535051092d871ded6cb053f5f
Gerrit-Change-Number: 13959
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/43bda841/attachment.htm>


More information about the gerrit-log mailing list