Change in osmo-msc[master]: no HO call forwarding if no RTP stream

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13940 )

Change subject: no HO call forwarding if no RTP stream
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13940/1/src/libmsc/msc_ho.c
File src/libmsc/msc_ho.c:

https://gerrit.osmocom.org/#/c/13940/1/src/libmsc/msc_ho.c@546
PS1, Line 546: rtp_to_ran = cl ? cl->rtp[RTP_TO_RAN] : NULL;
> Assigning NULL to 'rtp_to_ran' doesn't make sense anymore. […]
makes sense to me. I could do this:

  if (!cl) {
      error...
  }

  if (!cl->rtp[RTP_TO_RAN]) {
      error...
  }

instead I just

  rtp_to_ran = pointer or NULL
  if (!rtp_to_ran) {
    error...
  }

so it saves one if()

YMMV, but nothing wrong with this, right?



-- 
To view, visit https://gerrit.osmocom.org/13940
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia223c2e20e625879ab71fc5c8afd0305fd224c58
Gerrit-Change-Number: 13940
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 09 May 2019 14:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/af138068/attachment.htm>