Change in osmo-msc[master]: ran_a_make_handover_request(): allow no encryption

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu May 9 12:23:38 UTC 2019


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13938


Change subject: ran_a_make_handover_request(): allow no encryption
......................................................................

ran_a_make_handover_request(): allow no encryption

Fixes: coverity CID 198454
Change-Id: Ifb83ab2a8b6148b457224687ffada2dff4c3204f
---
M src/libmsc/ran_msg_a.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/13938/1

diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index 2e498a2..ba0990d 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -1068,7 +1068,8 @@
 
 		.speech_version_used = n->speech_version_used,
 
-		.chosen_encryption_algorithm_serving = n->geran.chosen_encryption->alg_id,
+		.chosen_encryption_algorithm_serving =
+			n->geran.chosen_encryption ? n->geran.chosen_encryption->alg_id : 0,
 
 		.old_bss_to_new_bss_info_raw = n->old_bss_to_new_bss_info_raw,
 		.old_bss_to_new_bss_info_raw_len = n->old_bss_to_new_bss_info_raw_len,

-- 
To view, visit https://gerrit.osmocom.org/13938
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb83ab2a8b6148b457224687ffada2dff4c3204f
Gerrit-Change-Number: 13938
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/2f0bb48b/attachment.htm>


More information about the gerrit-log mailing list