Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Wed May 8 17:47:37 UTC 2019


Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13929


Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx
......................................................................

libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

On receipt of DELETE PDP CTX CONF, don't call
sgsn_pdp_ctx_free() if we don't have an MM context.

Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
---
M src/gprs/sgsn_libgtp.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/13929/1

diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c
index a8a1502..582f420 100644
--- a/src/gprs/sgsn_libgtp.c
+++ b/src/gprs/sgsn_libgtp.c
@@ -565,14 +565,13 @@
 
 		/* Confirm deactivation of PDP context to MS */
 		rc = gsm48_tx_gsm_deact_pdp_acc(pctx);
+		sgsn_pdp_ctx_free(pctx);
 	} else {
 		LOGPDPCTXP(LOGL_NOTICE, pctx,
 			   "Not deactivating SNDCP layer since the MM context "
 			   "is not available\n");
 	}
 
-	sgsn_pdp_ctx_free(pctx);
-
 	return rc;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/13929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/ed9b42b2/attachment.htm>


More information about the gerrit-log mailing list