Change in osmo-msc[master]: vlr: optionally send IMEI early to HLR

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13894 )

Change subject: vlr: optionally send IMEI early to HLR
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c
File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@463
PS1, Line 463: 	/* If imeisv_early is enabled: IMEI already retrieved and checked (vlr_loc_upd_node1_pre), don't do it again. */
> Add a comment here like "if imeisv_eraly is enabled, we already have IMEI so no need to ask for it a […]
Done


https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@932
PS1, Line 932: 
> What would this message mean for a regular user (not a developer)? Either it should contain somethin […]
I've added it for consistency with related functions, that also log just their function name. But if you prefer, I can remove it or change it.


* vlr_loc_upd_node1

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n909

* lu_compl_vlr_new_tmsi

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n434

* vlr_loc_upd_node_4

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n791

* vlr_loc_upd_node_b

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n809

* vlr_loc_upd_post_ciph

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n830

* vlr_loc_upd_post_auth

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n863

* vlr_loc_upd_want_imsi

https://git.osmocom.org/osmo-msc/tree/src/libvlr/vlr_lu_fsm.c?id=5b1e0309b513ebe05a4b5b6dfa0c8ad620d34a99#n932


https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@937
PS1, Line 937: 	vlr_subscr_tx_req_check_imei(lfp->vsub);
             : 	} el
> Please fix the coding style: ... } else { ...
Done


https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@955
PS1, Line 955: 
> I guess if this happens, then we have a bug somewhere? I would rather OSMO_ASSERT(0) here... […]
It is done like this 6 other times in the file already, so I'd keep that for consistency.



-- 
To view, visit https://gerrit.osmocom.org/13894
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88283cad23793b475445d814ff49db534cb41244
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 06:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/b493210f/attachment.htm>