Change in osmo-bts[master]: common/oml.c: fix broken debug print in down_mom()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 5 16:27:22 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13879 )

Change subject: common/oml.c: fix broken debug print in down_mom()
......................................................................

common/oml.c: fix broken debug print in down_mom()

Change-Id: Ideac59946d50c6e06052a9590e02cfcfbf23d003
---
M src/common/oml.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/common/oml.c b/src/common/oml.c
index baf374a..62dea7b 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1411,8 +1411,8 @@
 		return oml_fom_ack_nack(msg, NM_NACK_BTSNR_UNKN);
 	}
 
-	/* FIXME: fix missing \n */
-	DEBUGPFOH(DOML, foh, "Rx IPACCESS(0x%02x): ", foh->msg_type);
+	DEBUGPFOH(DOML, foh, "Rx IPACCESS(0x%02x): %s\n", foh->msg_type,
+		  osmo_hexdump(foh->data, oh->length - sizeof(*foh)));
 
 	switch (foh->msg_type) {
 	case NM_MT_IPACC_RSL_CONNECT:

-- 
To view, visit https://gerrit.osmocom.org/13879
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ideac59946d50c6e06052a9590e02cfcfbf23d003
Gerrit-Change-Number: 13879
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190505/1c36de6b/attachment.htm>


More information about the gerrit-log mailing list