Change in libosmocore[master]: ipa: Fix ipa_ccm_id_resp_parse on big endian systems

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Mar 28 12:22:37 UTC 2019


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13432 )

Change subject: ipa: Fix ipa_ccm_id_resp_parse on big endian systems
......................................................................

ipa: Fix ipa_ccm_id_resp_parse on big endian systems

Change-Id: Iedc46ab53a4f76bbd98741c065fad3d9042a34a4
---
M src/gsm/ipa.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c
index 8e64a1e..1563d0a 100644
--- a/src/gsm/ipa.c
+++ b/src/gsm/ipa.c
@@ -204,8 +204,8 @@
 
 	while (len >= 3) {
 		len -= 3;
-		t_len = *cur++ << 8;
-		t_len += *cur++;
+		t_len = osmo_load16be(cur);
+		cur += 2;
 		t_tag = *cur++;
 
 		if (t_len > len + 1) {

-- 
To view, visit https://gerrit.osmocom.org/13432
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedc46ab53a4f76bbd98741c065fad3d9042a34a4
Gerrit-Change-Number: 13432
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190328/0e6a78f0/attachment.htm>


More information about the gerrit-log mailing list