This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13409 ) Change subject: Doxygen: fix documentation of rate_ctr_for_each_counter() ...................................................................... Doxygen: fix documentation of rate_ctr_for_each_counter() Doxygen was confused by duplicated documentation for both definition and declaration of rate_ctr_for_each_counter(). Moreover, both variants contained some mistakes. Let's avoid this duplication and keep the only (corrected) one. Change-Id: Icca2d4a95bd5f96ae85a86909ec90fb8677cacf3 --- M include/osmocom/core/rate_ctr.h M src/rate_ctr.c 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/include/osmocom/core/rate_ctr.h b/include/osmocom/core/rate_ctr.h index 865467c..f7e6e22 100644 --- a/include/osmocom/core/rate_ctr.h +++ b/include/osmocom/core/rate_ctr.h @@ -111,10 +111,6 @@ typedef int (*rate_ctr_group_handler_t)(struct rate_ctr_group *, void *); -/*! Iterate over all counters - * \param[in] handle_item Call-back function, aborts if rc < 0 - * \param[in] data Private data handed through to \a handle_counter - */ int rate_ctr_for_each_counter(struct rate_ctr_group *ctrg, rate_ctr_handler_t handle_counter, void *data); diff --git a/src/rate_ctr.c b/src/rate_ctr.c index c9319a6..82fddc6 100644 --- a/src/rate_ctr.c +++ b/src/rate_ctr.c @@ -385,7 +385,7 @@ } /*! Iterate over each counter in group and call function - * \param[in] counter group over whose counter to iterate + * \param[in] ctrg counter group over which to iterate * \param[in] handle_counter function pointer * \param[in] data Data to hand transparently to \ref handle_counter * \returns 0 on success; negative otherwise -- To view, visit https://gerrit.osmocom.org/13409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icca2d4a95bd5f96ae85a86909ec90fb8677cacf3 Gerrit-Change-Number: 13409 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/2ff154b9/attachment.htm>