Change in osmo-pcu[master]: pcu_l1_if: Fix erroneous endian-swapping of the CellID

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 07:39:00 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13369 )

Change subject: pcu_l1_if: Fix erroneous endian-swapping of the CellID
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13369/1/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/#/c/13369/1/src/pcu_l1_if.cpp@447
PS1, Line 447: info_ind->cell_id
> Don't we need to call ntohs() here?
there is no network byte order on the Osmocom unix domain socket related protocols like PCUIF, MNCC, ...



-- 
To view, visit https://gerrit.osmocom.org/13369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f6cc930c5dbf8dac386b24b0756df2efe8199e4
Gerrit-Change-Number: 13369
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 27 Mar 2019 07:39:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/c001a9d3/attachment.htm>


More information about the gerrit-log mailing list