This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py@540 PS2, Line 540: self._scc.sel_ctrl = "0004" #request an FCP > During my tests it did not break anything. […] Daniel's point remains: You're first setting the variable to 000C and then overwriting it with 0004. Just remove the first [bogus] assignment for cleanliness. Thanks! -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2019 07:23:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/11834042/attachment.htm>