This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h@8 PS1, Line 8: #define PCU_IF_VERSION 0x09 > Should we bump version as well? we only do that if we make incompatible changes like size/layout of structures. This patch is simply adding a new message type which any older receivers would log+drop, so it's safe to keep the version as-is https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2636 PS1, Line 2636: tlli = osmo_htonl(gsr->tlli); > shouldn't this be osmo_ntohl? correct, it's network to host order that we need here. -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:22:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190320/44813ce0/attachment.htm>