Change in osmo-sysmon[master]: Add vty option to print output of shell cmd on every poll step

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 06:42:54 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13304 )

Change subject: Add vty option to print output of shell cmd on every poll step
......................................................................


Patch Set 2:

The only place where "shell" is used, is in the commit log message.  I would strongly recommend to use "shell_cmd" everyhwere instead of just "cmd" or "cmmand". That includes structs, symbol names, VTY commands, ...

"command" is just too generic, IMHO.


-- 
To view, visit https://gerrit.osmocom.org/13304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I005773b75f81fa5f6c90f53af508fc6debea208b
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2019 06:42:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/a2f1db71/attachment.htm>


More information about the gerrit-log mailing list