Change in libosmo-sccp[master]: add caller-owns-msgb variant osmo_sccp_user_sap_down2()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 15 17:21:25 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13277 )

Change subject: add caller-owns-msgb variant osmo_sccp_user_sap_down2()
......................................................................


Patch Set 1:

what about the proposal with the 'volatile select dispatch talloc context'?

If we merge this patch, I think for sure the naming would have to be reworked.  The '2' function suffix is normally used only in case we have a new API that deprecates older API.  However, here we're adding something with different semantics, so those semantics should be expressed with something like _nofree or the like.  This way it's more obvious what those symbols are about.


-- 
To view, visit https://gerrit.osmocom.org/13277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic818efa78b90f727e1a94c18b60d9a306644f340
Gerrit-Change-Number: 13277
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 15 Mar 2019 17:21:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/6d0be062/attachment.htm>


More information about the gerrit-log mailing list