This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13191 )
Change subject: msc: for mo and mt call, interleave MGCP and Assignment
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/13191/2/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/#/c/13191/2/msc/BSC_ConnectionHandler.ttcn@533
PS2, Line 533: }
> I think this style is full on inconsistent with all other coding style everywhere else. […]
thanks. I'm to be blamed here, but I don't really see any other way in TTCN3 without wasting yet another layer of indentation :/
https://gerrit.osmocom.org/#/c/13191/2/msc/BSC_ConnectionHandler.ttcn@703
PS2, Line 703: }
> I mean just look at this one. That is what happens with this nonsense indenting. […]
what' your solution then? alt{} is basically like a switch statement, and I really don't want to loose one indent level. The way TTCN3 works you will then end up having two closing braces at one indent level somewhere.
--
To view, visit https://gerrit.osmocom.org/13191
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06af1e347601949f4ddb19f963daa400766d9e7
Gerrit-Change-Number: 13191
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 17:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/d6e82980/attachment.htm>