Change in osmo-bts[master]: oc2gbts_mgr_calib: do not return NULL on integer function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Mar 15 14:46:49 UTC 2019


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13272


Change subject: oc2gbts_mgr_calib: do not return NULL on integer function
......................................................................

oc2gbts_mgr_calib: do not return NULL on integer function

The functions oc2gbts_par_get_uptime() and oc2gbts_par_set_uptime() try
to return with NULL, but both functions are declared as int. Lets return
-EINVAL instead.

Change-Id: I63b61be2940c59b221089d3d1501371b0116d89a
---
M src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/13272/1

diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
index 55b1d77..2d12a49 100644
--- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
+++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
@@ -87,7 +87,7 @@
 
 	fpath = talloc_asprintf(ctx, "%s", UPTIME_TMP_PATH);
 	if (!fpath)
-		return NULL;
+		return -EINVAL;
 
 	fp = fopen(fpath, "r");
 	if (!fp)
@@ -117,7 +117,7 @@
 
 	fpath = talloc_asprintf(ctx, "%s", UPTIME_TMP_PATH);
 	if (!fpath)
-		return NULL;
+		return -EINVAL;
 
 	fp = fopen(fpath, "w");
 	if (!fp)

-- 
To view, visit https://gerrit.osmocom.org/13272
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63b61be2940c59b221089d3d1501371b0116d89a
Gerrit-Change-Number: 13272
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190315/da56dbc3/attachment.htm>


More information about the gerrit-log mailing list