This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@91 PS1, Line 91: osmo_timer_schedule(&scd->timer, 0, 0); > Can you at least document that in the code then? ACK, some small comment would be appreciated. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@106 PS1, Line 106: (i=0; i<scd->ct.perm_spch_len; i++) Cosmetic: spaces between '=' and '<' are missing. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@127 PS1, Line 127: ws https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@196 PS1, Line 196: struct gsm0808_channel_type Rather sizeof(*ct), so it would be safe to rename 'gsm0808_channel_type' symbol later on... Not critical though. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@199 PS1, Line 199: sizeof(scd->traffic_ip) Are you sure it would calculate the size of the string buffer and not the size of pointer? (Personally I'm always unsure in such cases, so testing is required) -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt at 246tNt.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 14 Mar 2019 08:12:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190314/72cfde98/attachment.htm>