This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition ...................................................................... Patch Set 7: (4 comments) https://gerrit.osmocom.org/#/c/13067/5/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13067/5/debian/copyright@9 PS5, Line 9: 2016-2019 sysmocom s.m.f.c. GmbH <info at sysmocom.de> > Update copyright year Done in separate patch. https://gerrit.osmocom.org/#/c/13067/5/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/5/src/coding_scheme.h@43 PS5, Line 43: uint8_t num_data_blocks(enum HeaderType ht); > What about using usual C style code in new functions we add? num_data_blocks() […] Ack https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.h File src/gprs_coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.h@a70 PS5, Line 70: > This one looks non-related, I didn't see it being moved somewhere else like other stuff. Ack https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.cpp File src/gprs_coding_scheme.cpp: https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.cpp@a320 PS5, Line 320: > Same. If it's really not used, drop it in another commit. Ack -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2019 16:21:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/3edaa9a9/attachment.htm>