This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/13214 ) Change subject: MCS: add mcs_is_*() helpers ...................................................................... Patch Set 1: (1 comment) I don't have a strong opinion on this though and we use 'egprs' way more often than 'edge' throughout the code so I can rename it. https://gerrit.osmocom.org/#/c/13214/1/src/coding_scheme.c File src/coding_scheme.c: https://gerrit.osmocom.org/#/c/13214/1/src/coding_scheme.c@54 PS1, Line 54: edge > EGPRS would be the more correct term here. […] Technically you're right: EDGE is more than just gprs-specific bits (which EGPRS is) - the spec usually talks about 'GSM/EDGE'. The reasoning behind this change is that in the context of PCU, we only deal with PS-related parts of EDGE anyway, so 'edge' and 'egprs' could be used interchangeably in this context - and "_edge" is slightly easier to read and has slightly lower chance of typos due to bigger dissimilarity between strings. -- To view, visit https://gerrit.osmocom.org/13214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6699cbc8d7ae766fa4d2b3d37e5f9ff1cf158b7e Gerrit-Change-Number: 13214 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Wed, 13 Mar 2019 11:26:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/4ea1f342/attachment.htm>