Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 13 10:24:46 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13163 )

Change subject: MCS: move Mode enum outside of class definition
......................................................................


Patch Set 2:

> do we actually need this outside of the context of the class?  Why are we worried how those strings are being generated?

That's pretty much cosmetic change. Having this in .c rather than .cpp makes it easier to use from both .c and .cpp code but that's just convenience. If you're absolutely against it than I can rewrite follow-up patches to not depend on this change.


-- 
To view, visit https://gerrit.osmocom.org/13163
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47
Gerrit-Change-Number: 13163
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 10:24:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/331824ec/attachment.htm>


More information about the gerrit-log mailing list