This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13204 ) Change subject: BSSGP: use variable for NSEI ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13204/1/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/#/c/13204/1/src/gb/gprs_bssgp.c@1039 PS1, Line 1039: ns_nsei 1) we don't assign values to multiple variables in one line 2) the naming "ns_nsei" makes no sense at all. A NSEI only exists at NS level. The variable "NS_BVCI" makes sense, as there are BVCIs at BSSGP level and also a BVCI in (some) NS messages. And they can difer. But for NSEI, this is different and the variable should just be called nsei. -- To view, visit https://gerrit.osmocom.org/13204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31 Gerrit-Change-Number: 13204 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Mon, 11 Mar 2019 16:47:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190311/3392d727/attachment.htm>