This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13191 ) Change subject: msc: for mo and mt call, interleave MGCP and Assignment ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13191/1/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/13191/1/msc/BSC_ConnectionHandler.ttcn@523 PS1, Line 523: > Cosmetic: why two tabs? […] oh indeed, cosmetic. Unfortunately gerrit coloring doesn't seem to catch that. two tabs because it makes more sense to me. Otherwise you can't optically distinguish the closing brace of the received message from the closing brace for the entire interlave (or alt) statement. AFAICT the indenting in these cases is inconsistent in our ttcn files, and I didn't want to - add two } } on the same indenting level or - have a closing } on the same level as its scope. i.e. be closer to the indenting we use in C. [EDIT] it seems a lot of places use alt { [] foo { content } } I find it a bit ugly but if you insist I can change to that... -- To view, visit https://gerrit.osmocom.org/13191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia06af1e347601949f4ddb19f963daa400766d9e7 Gerrit-Change-Number: 13191 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Sun, 10 Mar 2019 22:13:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190310/0be49d4c/attachment.htm>