This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13041 ) Change subject: resource: Add a mobile resource for the virtual test ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/#/c/13041/3/src/osmo_gsm_tester/ms.py File src/osmo_gsm_tester/ms.py: https://gerrit.osmocom.org/#/c/13041/3/src/osmo_gsm_tester/ms.py@52 PS3, Line 52: class Mobile(MS): Better move it to its own file, like ms_osmo_mobile.py Then calling the class MSOsmoMobile or similar. https://gerrit.osmocom.org/#/c/13041/3/src/osmo_gsm_tester/ms.py@54 PS3, Line 54: whitespace https://gerrit.osmocom.org/#/c/13041/3/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: https://gerrit.osmocom.org/#/c/13041/3/src/osmo_gsm_tester/resource.py@114 PS3, Line 114: 'mobile': ms.Mobile, osmo-mobile would be better imho, "mobile" is too generic to understand what it is right away. https://gerrit.osmocom.org/#/c/13041/3/suites/nitb_netreg_mass/suite.conf File suites/nitb_netreg_mass/suite.conf: https://gerrit.osmocom.org/#/c/13041/3/suites/nitb_netreg_mass/suite.conf@8 PS3, Line 8: type: mobile osmo-mobile -- To view, visit https://gerrit.osmocom.org/13041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic26aa63cad62323bb85f952640672eb28af0eadc Gerrit-Change-Number: 13041 Gerrit-PatchSet: 3 Gerrit-Owner: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2019 15:25:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/480c7924/attachment.htm>