Change in osmo-pcu[master]: MCS: remove dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 4 16:25:12 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13063 )

Change subject: MCS: remove dead code
......................................................................

MCS: remove dead code

As a preparation for (M)CS fixes in follow-up patches, remove unused
operators from GprsCodingScheme class.

Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
---
M src/gprs_coding_scheme.h
1 file changed, 0 insertions(+), 14 deletions(-)

Approvals:
  Holger Freyther: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 6087416..1acb14b 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -212,20 +212,6 @@
 		GprsCodingScheme::Scheme(a) < GprsCodingScheme::Scheme(b);
 }
 
-inline bool operator >(GprsCodingScheme a, GprsCodingScheme b)
-{
-	return b < a;
-}
-
-inline bool operator <=(GprsCodingScheme a, GprsCodingScheme b)
-{
-	return a == b || a < b;
-}
-
-inline bool operator >=(GprsCodingScheme a, GprsCodingScheme b)
-{
-	return a == b || a > b;
-}
 inline GprsCodingScheme::Scheme GprsCodingScheme::get_retx_mcs(
 				const GprsCodingScheme mcs,
 				const GprsCodingScheme demanded_mcs,

-- 
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190304/19241aa7/attachment.htm>


More information about the gerrit-log mailing list