Change in osmo-bsc[master]: lchan_fsm: make sure multi rate configuration is valid

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13094 )

Change subject: lchan_fsm: make sure multi rate configuration is valid
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13094/1/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/#/c/13094/1/src/osmo-bsc/lchan_fsm.c@542
PS1, Line 542: 		if (gsm48_mr_cfg_from_gsm0808_sc_cfg(&mr_conf, info->s15_s0) < 0) {
do we have a test case for this? Can we actually reasonably have one? Is it possible to send S-bits from the MSC in a TTCN-3 test that trigger this?  I basically want to see some validation that this really fails gracefully.



-- 
To view, visit https://gerrit.osmocom.org/13094
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd3e5674b10b8ae223c0d13ae33fc9ae7e8a8a18
Gerrit-Change-Number: 13094
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 01 Mar 2019 18:07:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190301/ddedbc9a/attachment.htm>