Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: legacy flag is only for version 0x00

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 24 14:16:17 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14584


Change subject: trx_toolkit/data_msg.py: legacy flag is only for version 0x00
......................................................................

trx_toolkit/data_msg.py: legacy flag is only for version 0x00

Since version 0x01, the burst bits are encoded as L16V,
so appending two dummy octets doesn't make sense.

Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3
---
M src/target/trx_toolkit/data_msg.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/84/14584/1

diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py
index 7e6ee2e..66fe3c1 100644
--- a/src/target/trx_toolkit/data_msg.py
+++ b/src/target/trx_toolkit/data_msg.py
@@ -258,7 +258,7 @@
 
 		# This is a rudiment from (legacy) OpenBTS transceiver,
 		# some L1 implementations still expect two dummy bytes.
-		if legacy:
+		if legacy and self.ver == 0x00:
 			buf += bytearray(2)
 
 		return buf

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14584
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3
Gerrit-Change-Number: 14584
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190624/32782a34/attachment.htm>


More information about the gerrit-log mailing list