This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14483 ) Change subject: encoding: use `/* */` for comments instead of `#if 0 #endif` ...................................................................... encoding: use `/* */` for comments instead of `#if 0 #endif` Change-Id: Ifff9526b15bfda7a0f85c92bcb0d3fabab61ca32 --- M src/encoding.cpp 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/encoding.cpp b/src/encoding.cpp index b6879cc..530cba7 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -853,8 +853,8 @@ bool len_coded = true; uint8_t crbb_start_clr_code; uint8_t i; -#if 0 - /* static size of 16 bits*/ + + /* static size of 16 bits ..0. .... = ACKNACK: (Union) Desc @@ -866,8 +866,7 @@ .... ..10 0101 0001 1... .... = STARTING_SEQUENCE_NUMBER: 1187 - .0.. .... = CRBB Exist: 0 -#endif + .0.. .... = CRBB Exist: 0 */ rest_bits -= 16; if (num_blocks > 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifff9526b15bfda7a0f85c92bcb0d3fabab61ca32 Gerrit-Change-Number: 14483 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190617/b3cf3cfb/attachment.htm>