Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_mo_ussd_for_unknown_trans

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14503 )

Change subject: MSC_Tests.ttcn: introduce TC_mo_ussd_for_unknown_trans
......................................................................

MSC_Tests.ttcn: introduce TC_mo_ussd_for_unknown_trans

The new test case is aimed to verify that OsmoMSC properly does
reject (call independent) SS/USSD messages for non-existing
transactions.

Change-Id: I231142c88b0d3308039c797aa2bccadd79dce18b
Related: OS#2931
---
M msc/MSC_Tests.ttcn
1 file changed, 60 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index b0834a4..b00e032 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -3509,6 +3509,65 @@
 	vc_conn.done;
 }
 
+/* MO (mobile-originated) SS/USSD for unknown transaction */
+friend function f_tc_mo_ussd_for_unknown_trans(charstring id, BSC_ConnHdlrPars pars)
+runs on BSC_ConnHdlr {
+	f_init_handler(pars);
+
+	f_ran_register_imsi(g_pars.imsi, 'FFFFFFFF'O);
+	f_create_gsup_expect(hex2str(g_pars.imsi));
+
+	/* Perform location update */
+	f_perform_lu();
+
+	/* Send CM Service Request for SS/USSD */
+	f_establish_fully(EST_TYPE_SS_ACT);
+
+	/* GSM 04.80 FACILITY message for a non-existing transaction */
+	var template (value) PDU_ML3_MS_NW mo_ss_fac := ts_ML3_MO_SS_FACILITY(
+		tid := 1, /* An arbitrary transaction identifier */
+		ti_flag := c_TIF_ORIG, /* Sent from the side that originates the TI */
+		facility := f_rnd_octstring(23) /* We don't care about the Facility IE */
+	);
+
+	/* GSM 04.80 RELEASE COMPLETE message for a non-existing transaction */
+	var template (value) PDU_ML3_MS_NW mo_ss_rel := ts_ML3_MO_SS_RELEASE_COMPLETE(
+		tid := 1, /* An arbitrary transaction identifier */
+		ti_flag := c_TIF_ORIG, /* Sent from the side that originates the TI */
+		facility := f_rnd_octstring(23) /* We don't care about the Facility IE */
+	);
+
+	/* Expected response from the network */
+	var template PDU_ML3_NW_MS mt_ss_rel := tr_ML3_MT_SS_RELEASE_COMPLETE(
+		tid := 1, /* Same as in the FACILITY message */
+		ti_flag := c_TIF_REPL, /* Sent to the side that originates the TI */
+		facility := omit
+	);
+
+	/* Send GSM 04.80 FACILITY for non-existing transaction */
+	BSSAP.send(ts_PDU_DTAP_MO(mo_ss_fac));
+
+	/* Expect GSM 04.80 RELEASE COMPLETE message */
+	f_expect_mt_dtap_msg(mt_ss_rel);
+	f_expect_clear();
+
+	/* Send another CM Service Request for SS/USSD */
+	f_establish_fully(EST_TYPE_SS_ACT);
+
+	/* Send GSM 04.80 RELEASE COMPLETE for non-existing transaction */
+	BSSAP.send(ts_PDU_DTAP_MO(mo_ss_rel));
+
+	/* Expect GSM 04.80 RELEASE COMPLETE message */
+	f_expect_mt_dtap_msg(mt_ss_rel);
+	f_expect_clear();
+}
+testcase TC_mo_ussd_for_unknown_trans() runs on MTC_CT {
+	var BSC_ConnHdlr vc_conn;
+	f_init();
+	vc_conn := f_start_handler(refers(f_tc_mo_ussd_for_unknown_trans), 111);
+	vc_conn.done;
+}
+
 /* MT (network-originated) USSD for unknown session */
 friend function f_tc_proc_ss_for_unknown_session(charstring id, BSC_ConnHdlrPars pars)
 runs on BSC_ConnHdlr {
@@ -5542,6 +5601,7 @@
 	execute( TC_lu_and_ss_session_timeout() );
 
 	execute( TC_mt_ussd_for_unknown_subscr() );
+	execute( TC_mo_ussd_for_unknown_trans() );
 	execute( TC_proc_ss_for_unknown_session() );
 	execute( TC_proc_ss_paging_fail() );
 	execute( TC_proc_ss_abort() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14503
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I231142c88b0d3308039c797aa2bccadd79dce18b
Gerrit-Change-Number: 14503
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190617/89f6e653/attachment.htm>