This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14466 Change subject: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging ...................................................................... libmsc/gsm_09_11.c: drop meaningless check for concurrent paging This check was copy-pasted from the CC handling code during the initial development of "SS/USSD over GSUP" feature. It probably makes sense for MT calls, but definitely not for SS/USSD. Change-Id: I2899a23ee49fd7917443943629603700a5025cf4 --- M src/libmsc/gsm_09_11.c 1 file changed, 1 insertion(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/14466/1 diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 87978a5..4f9f127 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -314,7 +314,7 @@ struct vlr_subscr *vsub, const struct osmo_gsup_message *gsup_msg) { struct msc_a *msc_a; - struct gsm_trans *trans, *transt; + struct gsm_trans *trans; int tid; if (gsup_msg->session_state != OSMO_GSUP_SESSION_STATE_BEGIN) { @@ -364,20 +364,6 @@ LOG_TRANS(trans, LOGL_DEBUG, "Triggering Paging Request\n"); - /* Find transaction with this subscriber already paging */ - llist_for_each_entry(transt, &net->trans_list, entry) { - /* Transaction of our conn? */ - if (transt == trans || transt->vsub != vsub) - continue; - - LOG_TRANS(trans, LOGL_ERROR, "Paging already started, " - "rejecting message...\n"); - trans_free(trans); - /* FIXME: WTF IS THIS!? This is completely insane. Presence of a trans doesn't indicate Paging, and even - * if, why drop the current request??? */ - return NULL; - } - /* Trigger Paging Request */ trans->paging_request = paging_request_start(vsub, PAGING_CAUSE_SIGNALLING_HIGH_PRIO, ss_paging_cb, trans, "GSM 09.11 SS/USSD"); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2899a23ee49fd7917443943629603700a5025cf4 Gerrit-Change-Number: 14466 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190615/31ba435c/attachment.htm>