Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: use f_expect_gsup_msg() in f_tc_mt_ussd_for_unknown_s...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Jun 15 08:48:39 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14459 )

Change subject: MSC_Tests.ttcn: use f_expect_gsup_msg() in f_tc_mt_ussd_for_unknown_subscr()
......................................................................

MSC_Tests.ttcn: use f_expect_gsup_msg() in f_tc_mt_ussd_for_unknown_subscr()

Change-Id: Id067cee3b7d06613d8387e0fa9d8a5c1dbcc49cf
---
M msc/MSC_Tests.ttcn
1 file changed, 1 insertion(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index b66323b..b8f9fd7 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -3474,7 +3474,6 @@
 runs on BSC_ConnHdlr {
 	var hexstring imsi := '000000000000000'H; /* Some unknown IMSI */
 	var OCT4 sid := '20000222'O;
-	timer T := 2.0;
 
 	f_init_handler(pars);
 	f_ran_register_imsi(imsi, 'FFFFFFFF'O);
@@ -3499,17 +3498,7 @@
 	GSUP.send(gsup_req);
 
 	/* Expect GSUP PROC_SS_ERROR message */
-	T.start;
-	alt {
-	[] GSUP.receive(gsup_rsp) {
-		setverdict(pass);
-		};
-	[] T.timeout {
-		setverdict(fail, "Timeout waiting for GSUP PROC_SS_ERROR message");
-		}
-	/* We don't expect anything else */
-	[] as_unexp_gsup_or_bssap_msg();
-	}
+	f_expect_gsup_msg(gsup_rsp);
 }
 testcase TC_mt_ussd_for_unknown_subscr() runs on MTC_CT {
 	var BSC_ConnHdlr vc_conn;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14459
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id067cee3b7d06613d8387e0fa9d8a5c1dbcc49cf
Gerrit-Change-Number: 14459
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190615/695b2166/attachment.htm>


More information about the gerrit-log mailing list