This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14453 Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit session IEs ...................................................................... gsup_client_mux_tx_error_reply(): fix: do not omit session IEs For SS/USSD, it's important to have both session state and ID IEs. Found using the new TC_mt_ussd_for_unknown_subscr test case. Change-Id: I57317a7b8036d1ffd36e2021efc146db4633da84 Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe Related: OS#2931 --- M src/libmsc/gsup_client_mux.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/14453/1 diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c index 292c2a9..6bac7b2 100644 --- a/src/libmsc/gsup_client_mux.c +++ b/src/libmsc/gsup_client_mux.c @@ -157,6 +157,12 @@ OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi); + /* For SS/USSD, it's important to keep both session state and ID IEs */ + if (gsup_orig->session_state != OSMO_GSUP_SESSION_STATE_NONE) { + gsup_reply.session_state = gsup_orig->session_state; + gsup_reply.session_id = gsup_orig->session_id; + } + if (osmo_gsup_client_enc_send(gcm->gsup_client, &gsup_reply)) LOGP(DLGSUP, LOGL_ERROR, "Failed to send Error reply (imsi=%s)\n", osmo_quote_str(gsup_orig->imsi, -1)); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I57317a7b8036d1ffd36e2021efc146db4633da84 Gerrit-Change-Number: 14453 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190614/ab942cff/attachment.htm>