This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14439 ) Change subject: logging: introduce LOG_BTS and LOG_TRX and use it everywhere ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/abis_nm.c@1704 PS2, Line 1704: int abis_nm_get_attr(struct gsm_bts *bts, uint8_t obj_class, uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr, Looks like we should be passing here "struct gsm_bts_trx *trx" instead of "bts" + "trx_nr". Also, I guess bts_nr is contained already in "bts" ? https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/acc_ramp.c File src/osmo-bsc/acc_ramp.c: https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/acc_ramp.c@170 PS2, Line 170: if (trx->nr != 0) If we only care about first TRX, I'm not sure it makes sense to use LOG_TRX in this function and use better LOG_BTS. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c Gerrit-Change-Number: 14439 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jun 2019 15:41:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190613/fb172956/attachment.htm>